Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for int32_t indices in TBE training (2E/N) #3375

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 14, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65933410

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 6048e86
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/6786b956b769ae0008bf13a5
😎 Deploy Preview https://deploy-preview-3375--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@q10 q10 force-pushed the export-D65933410 branch from c7bf4dc to 309d912 Compare December 14, 2024 22:29
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

@q10 q10 force-pushed the export-D65933410 branch from 309d912 to f6eac52 Compare December 14, 2024 22:29
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@q10 q10 force-pushed the export-D65933410 branch from f6eac52 to cb705e1 Compare January 2, 2025 20:37
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
Summary:
X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@q10 q10 force-pushed the export-D65933410 branch from cb705e1 to 419bcda Compare January 6, 2025 21:41
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 9, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
@q10 q10 force-pushed the export-D65933410 branch from 7db443a to 14cf7ff Compare January 10, 2025 22:34
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 10, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 11, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
@q10 q10 force-pushed the export-D65933410 branch from 14cf7ff to 6048e86 Compare January 14, 2025 19:21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65933410

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#621

X-link: facebookresearch/FBGEMM#466


- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65933410
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in c7bca8a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants