address reviewer comments #2815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
# context
* use `at::parallel_for` to run a parallel threading in CPU kernel
* somehow the results are wrong.
```
(Pdb) outputs[0]
tensor([[-6.4628e-01, -1.9817e+00, -8.4945e-01, 1.3860e+00, 7.4463e-01,
1.3079e-01, 8.5881e-01, -7.4804e-01],
[-2.3989e-01, 1.2933e+00, 1.3789e+00, -1.9305e+00, -5.7734e-01,
-4.5220e-01, -1.3703e+00, -1.9221e+00],
[ 1.2582e+00, 1.2426e+00, 2.6749e-01, 6.8250e-01, 7.0065e-45,
0.0000e+00, 0.0000e+00, 0.0000e+00],
[-4.5382e-02, -9.4207e-01, 7.1254e-01, 7.8096e-01, -1.3482e+00,
-1.2763e+00, 4.2996e-01, -8.9042e-01],
[-5.8892e-02, 1.1909e+00, -1.4653e+00, 0.0000e+00, 0.0000e+00,
0.0000e+00, 0.0000e+00, 0.0000e+00],
[ 1.0306e-01, 2.2235e-01, 1.6044e+00, -3.0457e-01, 1.6609e+00,
4.1478e-43, 0.0000e+00, 0.0000e+00]],
grad_fn=<PermuteMultiEmbeddingOp>>)
(Pdb) refs[0]
tensor([[-0.6463, -1.9817, -0.8494, 0.8588, -0.7480, -1.0166, 1.3860, 0.7446],
[ 1.3572, 0.0403, -0.2078, -0.8592, 0.4000, 1.0562, -0.2399, 1.2933],
[-0.8118, -0.8703, -0.1429, -0.0802, 0.2706, -0.6728, 1.2582, 1.2426],
[ 0.0026, -1.3482, -1.2763, 0.9094, 1.2502, 0.5035, -0.0454, -0.9421],
[-1.4653, 0.8384, -0.3290, -1.2008, -0.4272, -1.0376, 1.0920, 0.2197],
[ 1.4819, 0.1565, -0.1601, -0.8323, -0.0130, 0.4165, 0.1031, 0.2223]],
grad_fn=<CatBackward0>)
```
Reviewed By: sryap
Differential Revision: D38300272
|
This pull request was exported from Phabricator. Differential Revision: D38300272 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request was exported from Phabricator. Differential Revision: D38300272 |
3 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D38300272 |
|
This pull request was exported from Phabricator. Differential Revision: D38300272 |
|
This pull request was exported from Phabricator. Differential Revision: D38300272 |
|
This pull request has been merged in b903979. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
at::parallel_forto run a parallel threading in CPU kernelReviewed By: sryap
Differential Revision: D38300272