Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on pytorch built with CUDA 11.3 #1237

Closed
wants to merge 1 commit into from
Closed

Run CI on pytorch built with CUDA 11.3 #1237

wants to merge 1 commit into from

Conversation

mjanderson09
Copy link
Contributor

Summary:

  • pytorch has not updated their CUDA 11.5 .whl files with latest pytorch (1.13), while they have updated their CUDA 11.3 .whl files
  • pytorch built with CUDA 11.3 will work with later CUDA versions, as CUDA is backward compatable
  • Suggest we set a policy where we support building/installing FBGEMM with pytorch .whl which is built with CUDA 11.3 as this seems to be their preferred build. This guidance in our README and also torchrec README.
  • This diff updates CI to install pytorch .whl which was built with CUDA 11.3, even when testing FBGEMM with later CUDA versions

Differential Revision: D38416122

@mjanderson09 @facebook-github-bot
Run CI on pytorch built with CUDA 11.3
ca8e32d 
Summary:
- pytorch has not updated their CUDA 11.5 .whl files with latest pytorch (1.13), while they have updated their CUDA 11.3 .whl files
- pytorch built with CUDA 11.3 will work with later CUDA versions, as CUDA is backward compatable
- Suggest we set a policy where we support building/installing FBGEMM with pytorch .whl which is built with CUDA 11.3 as this seems to be their preferred build. This guidance in our README and also torchrec README.
- This diff updates CI to install pytorch .whl which was built with CUDA 11.3, even when testing FBGEMM with later CUDA versions

Differential Revision: D38416122

fbshipit-source-id: c79d9b678c1b0a2a740093757f3d0787db3da346
@netlify
Copy link

netlify bot commented Aug 4, 2022 •
edited
Loading

✅ Deploy Preview for eclectic-stroopwafel-199537 canceled.

Name Link
🔨 Latest commit ca8e32d
🔍 Latest deploy log https://app.netlify.com/sites/eclectic-stroopwafel-199537/deploys/62eb5567bbc7a80008d1b6d9

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D38416122

shintaro-iwasaki
shintaro-iwasaki approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@shintaro-iwasaki shintaro-iwasaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a truly "nightly" PyTorch build.
I overlooked this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shintaro-iwasaki shintaro-iwasaki shintaro-iwasaki approved these changes

Assignees
No one assigned
Labels
cla signed fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mjanderson09 @facebook-github-bot @shintaro-iwasaki