Update asmjit submodule for OSS #1202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-stroopwafel-199537 canceled.
|
|
This pull request was exported from Phabricator. Differential Revision: D37763232 |
Closed
Summary: Pull Request resolved: pytorch#1202 Update OSS asmjit version to d3fbf7c9bc7c1d1365a94a45614b91c5a3706b81, sync with the third-party/asmjit. Add a -Wno-unused-variable compilation flag to enable Clang 14. Reviewed By: brad-mengchi, jianyuh Differential Revision: D37763232 fbshipit-source-id: e70e387408d0b851297465f66fc81d065a9a284c
|
This pull request was exported from Phabricator. Differential Revision: D37763232 |
|
Can we please land this ? It fixes builds on latest versions of clang that is bundled in Ubuntu 22.04. See here for an example failure: https://github.com/llvm/torch-mlir/runs/7464486170?check_suite_focus=true#step:4:1663 |
|
@powderluv Landing the PR. |
|
Do you know who can update the Pytorch FBGEMM submodule. I think the automatic submodule updater stopped working and FBGEMM is pinned to something from three months ago. Happy to submit a PR if required. |
|
Here is a PR for updating PyTorch FBGEMM pytorch/pytorch#82396 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D37763232