Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile decorator may need to use functools.wrap #299

Closed
staftermath opened this issue Nov 29, 2020 · 0 comments · Fixed by #300
Closed

profile decorator may need to use functools.wrap #299

staftermath opened this issue Nov 29, 2020 · 0 comments · Fixed by #300

Comments

@staftermath
Copy link
Contributor

I recently was trying to profile the difference between pandas and modin, and ran into an issue with the profile decorator. After some digging I found that both profile and modin may be at fault. I am making a fix at modin's end to address the root cause . Basically, I believe profile may need to use functools.wraps when creating a wrapped function, that may prevent adding unwanted local variables. I can make a PR if you like.

P.S. thanks for this great tool. I just did a demo of some of my stuff at work to my colleague and used this for illustration purposes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant