Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

really drop python<=3.7 support #351

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kloczek
Copy link

@kloczek kloczek commented Oct 3, 2024

Filter all code over pyupgracde --py38-plus.

Filter all code over `pyupgracde --py38-plus`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
@kloczek
Copy link
Author

kloczek commented Oct 3, 2024

BTW end of this month 3.8 will be EOSed.

Copy link

github-actions bot commented Nov 1, 2024

This pull request is stale because it has been open for 4 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.

@github-actions github-actions bot added the stale label Nov 1, 2024
@kloczek
Copy link
Author

kloczek commented Nov 1, 2024

Any update? 🤔

@github-actions github-actions bot removed the stale label Nov 2, 2024
@jborean93
Copy link
Contributor

Sorry I didn't get to this earlier. I'm reluctant to merging in stylistic changes without having an actual check in CI to back it for future commits. Granted there are still some Python 2-isms still in there that this PR is fixing but making these changes doesn't really achieve to much in the long run.

If I was really wanting to do something like this I would prefer to just have something like black to go over the codebase.

@kloczek
Copy link
Author

kloczek commented Nov 13, 2024

black is the Python code formatter.
pyupgrade replaces syntax to more effective handled by exact Python version (please read pyupgrade documentation for details).
gssapi passes pytest test suite with this PR.
Did you test this PR? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants