Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more flexible dependencies in METADATA.toml? #4995

Closed
ilevkivskyi opened this issue Feb 1, 2021 · 2 comments
Closed

Support more flexible dependencies in METADATA.toml? #4995

ilevkivskyi opened this issue Feb 1, 2021 · 2 comments
Labels
project: infrastructure typeshed build, test, documentation, or distribution related

Comments

@ilevkivskyi
Copy link
Member

Currently only simple dependencies like types-foo or types-bar>=1.2 are supported. Here are some ideas for more flexibility (both format and logic):

  • Allow spaces and/or quotes for versions
  • Allow multiple version conditions, like types-foo>1,<2 (supported by pip)
  • Allow python-version-specific dependencies, like types-foo>=1.2; python_version>3.7
  • Allow depending on trusted third party inline packages

Last one (or two?) may require some non-trivial work w.r.t. to mypy/pytype tests.

@srittau
Copy link
Collaborator

srittau commented Feb 1, 2021

I think especially the second and fourth point will eventually be necessary. But we can implement this when we need it, I guess.

@AlexWaygood AlexWaygood added the project: infrastructure typeshed build, test, documentation, or distribution related label Jun 12, 2022
@hauntsaninja
Copy link
Collaborator

Yeah, agreed on implementing things as they come up, e.g. we have #5768

Note that packaging makes parsing specifiers easy, so we should minimise doing things ourselves with regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project: infrastructure typeshed build, test, documentation, or distribution related
Projects
None yet
Development

No branches or pull requests

4 participants