Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting WASI to tier 2 #223

Closed
brettcannon opened this issue Nov 30, 2023 · 2 comments
Closed

Promoting WASI to tier 2 #223

brettcannon opened this issue Nov 30, 2023 · 2 comments

Comments

@brettcannon
Copy link
Member

brettcannon commented Nov 30, 2023

I would like to find out what the SC would like to see happen to promote WASI support to tier 2? I have tried to simplify the development process via python/cpython#112473 so that anyone needing to debug a failure under WASI can do so (plus the devcontainer for the CPython repo has the tools necessary). Luckily the failures are almost always test assumptions around threading or certain stack sizes existing.

Some possible things to ask of me (beyond the obvious tier 2 requirements):

  • Fix the tests causing pydebug builds from blowing their stacks
  • Update docs.python.org to not say "not WASI" but instead explicit enumerate the supported platforms (i.e. Linux, macOS, Windows)
  • Set up a dedicated devcontainer for WASI so it's available fully built in a Codespace (this would complicate the configuration for devcontainers since it would effectively duplicate anything common, plus it technically costs the PSF money)
  • Switch to CI coverage instead of relying on buildbots
  • A container uploaded somewhere with the tools
@Yhg1s
Copy link
Member

Yhg1s commented Jan 25, 2024

The SC decided the process for promoting can just be:

  • Make sure you satisfy all the requirements for the next tier, including being ready to support it adequately e.g. have two core devs ready to actively support it; for promotion to tier 1 that would mean getting consensus among core devs.
  • Rope in the RM of the release(s) you're targeting to make sure they're satisfied (since that's me, ✔️)
  • Send a PR to update PEP 11.
  • ???
  • Profit.

CI is highly desirable (since it's much harder to discover buildbot breakages than CI ones, although with our current Developers-in-Residence that's improving quite a lot), but we don't want to make it a requirement for tier 2 promotion since CI may not be an option for some platforms. The extra things you're suggesting we ask for may be desirable to get to the support level you and the other designated maintainers want to provide, and probably would be necessary to get consensus among core devs for tier 1 support, but as far as we're concerned they're not a requirement for getting to tier 2.

@Yhg1s Yhg1s closed this as completed Jan 25, 2024
@brettcannon
Copy link
Member Author

Thanks so much! I'll still move the docs to the devguide before I update PEP 11. I also still plan to try out a CI solution to see if it can run fast enough to not be a bottleneck.

And mostly for the RM, I got a debug build buildbot up and running today. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants