Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margins of definition lists in the Sphinx theme #2300

Closed
AA-Turner opened this issue Feb 3, 2022 · 3 comments · Fixed by #2427
Closed

Fix margins of definition lists in the Sphinx theme #2300

AA-Turner opened this issue Feb 3, 2022 · 3 comments · Fixed by #2427
Assignees

Comments

@AA-Turner
Copy link
Member

... we really need to fix the margins of the definition lists in the Sphinx theme. There is almost no margin/padding between definitions, much less than even normal <p>s, making it very hard to read, while there is at least the normal (adequate) spacing if the definition has multiple paragraphs.

Originally posted by @CAM-Gerlach in #2298 (comment)

@AA-Turner
Copy link
Member Author

I've a further implementation PR I'm working on that does the reference title changes -- I'll look into this whilst preparing that one.

A

@AA-Turner AA-Turner self-assigned this Feb 3, 2022
@CAM-Gerlach
Copy link
Member

@AA-Turner It looks like this is still outstanding, so if you're busy I can tackle this.

@CAM-Gerlach
Copy link
Member

@pradyunsg mentioned on the styling thread that definition lists are also missing indentation on the definition on the definition, which can be fixed here too, and perhaps co-opting some other styling (vertical rules) from the previous system and other themes.

If you don't get to this in 24 hours, I'll go ahead and take care of it instead, since its just frontend CSS rather than any backend changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants