Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 484: NewType is now a class, not a function #2199

Closed
Fidget-Spinner opened this issue Dec 18, 2021 · 6 comments
Closed

PEP 484: NewType is now a class, not a function #2199

Fidget-Spinner opened this issue Dec 18, 2021 · 6 comments

Comments

@Fidget-Spinner
Copy link
Member

Since Python 3.10, we've changed PEP 484's NewType to a class, not a function, so this section is misleading.

Should we update it? Or do we leave it as is?

CC @JelleZijlstra and @gvanrossum

@AlexWaygood
Copy link
Member

I recently had a PR to the mypy docs accepted, tackling this issue: python/mypy#11621

I think similar changes to PEP 484 would be good.

@JelleZijlstra
Copy link
Member

PEPs are historical documents, not living documentation, and at some point we should stop changing them. I guess we previously discussed this in #1942 and #2158.

For this particular change, I don't think it's especially important that PEP 484 is exactly correct. It's just an implementation detail.

@gvanrossum
Copy link
Member

Indeed. PEP 484 is no longer provisional.

@CAM-Gerlach
Copy link
Member

Indeed. PEP 484 is no longer provisional.

@gvanrossum It looks like it is still marked as such—should it be updated?

@gvanrossum
Copy link
Member

Yeah, should be Final. :-)

@CAM-Gerlach
Copy link
Member

Opened as PR #2380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants