Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifted footnotes on PEP 595 #1098

Closed
JulienPalard opened this issue Jun 4, 2019 · 3 comments · Fixed by #2534
Closed

Shifted footnotes on PEP 595 #1098

JulienPalard opened this issue Jun 4, 2019 · 3 comments · Fixed by #2534
Assignees

Comments

@JulienPalard
Copy link
Member

Looks like footnotes are shifted on PEP 595:

This concern has been raised in the past in a Zulip topic [19].

[...]

[19] The New-bugs-announce mailing list

@gvanrossum
Copy link
Member

You're right, they're out of sync. Probably something in the doc confuses the code that numbers footnotes? (Personally I don't like bottom-notes -- I prefer inline URLs. But that's a separate battle.)

@hugovk
Copy link
Member

hugovk commented Apr 17, 2022

Please see PR #2534 to fix this.

@CAM-Gerlach CAM-Gerlach changed the title Shifted footnotes on pep 595 Shifted footnotes on PEP 595 Apr 17, 2022
@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Apr 17, 2022

There's actually quite a few instances of that throughout older PEPs; a lot of the ≈250 Sphinx warnings relate (ultimately) to misaligned footnote numbering. It wouldn't have been an issue if authors just used named auto-numbered footnotes instead of hardcoded or implicit numbers, but until I updated it recently, PEP 12 described both methods and lacked a clear recommendation (now it only specifies named auto-numbered footnotes, in cases where footnotes and not direct links are actually required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants