Remove special casing for "cannot" in error messages #15365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tripped me up the other day when grepping for an error message. Thanks to ikonst's --update-data improvements, trivial to fix everywhere.
| @@ -2019,7 +2019,7 @@ tmp/foo.pyi:5: note: @overload | |||
| tmp/foo.pyi:5: note: def __add__(self, int, /) -> int | |||
| tmp/foo.pyi:5: note: @overload | |||
| tmp/foo.pyi:5: note: def __add__(self, str, /) -> str | |||
| tmp/foo.pyi:5: note: Overloaded operator methods cannot have wider argument types in overrides | |||
There was a problem hiding this comment.
Feel like it's better to change all these to "cannot" in the place where we generate the message; "can't" is a little too informal.
|
That was what I was about to do next ;) |
|
A handful of errors remain: Can we merge this? I think it'll be nice to collapse some |
|
If @hauntsaninja is too busy to finish this PR, feel free to create an alternative PR finishing this one, and I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tripped me up the other day when grepping for an error message. Thanks to ikonst's --update-data improvements, very easy to fix everywhere.