Cherry pick the typeshed fix for 12339 #12340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The typeshed fix works fine, but is basically a hack to work around a bug in mypy. @sobolevn worked out how to fix the actual bug in #12134. #12134 is still a work in progress — but maybe it would be good to excise the |
|
If we want to do a bugfix mypy release it's probably easier to merge this simple change. |
Yes, fair enough — best to keep it simple. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JukkaL
approved these changes
Mar 14, 2022
JukkaL
pushed a commit
that referenced
this pull request
Mar 14, 2022
…age.pyi` (#7022) (#12340) Co-authored-by: Chris Rose <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Typeshed cherry-pick: Use import instead of type alias in
email/message.pyi(#7022)Fixes #12339
(Explain how this PR changes mypy.)
I've confirmed that this resolves the type checking error introduced in 0.940 using hamcrest as a testbed.