Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stubtest usability for py files #13195

Open
hauntsaninja opened this issue Jul 20, 2022 · 1 comment
Open

Improve stubtest usability for py files #13195

hauntsaninja opened this issue Jul 20, 2022 · 1 comment
Assignees
@hauntsaninja
Labels
feature topic-stubtest

Comments

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Jul 20, 2022 •
edited
Loading

Currently stubtest is very happy to treat "py" files as sources of type definitions. This is very useful, because it makes it easy to check packages that have mixed inline types and stubs (that may depend on each other).

But it does mean there is some counterintuitive behaviour where you'd expect to see something like "failed to find stubs". Basically, is it possible to salvage #12889 , #12896 (without becoming complicated enough that behaviour is unpredictable)?

Should also look into resolving some of the differences in the mypy build. Not going into detail (this is mostly a reminder for myself), but here are some links:
pandas-dev/pandas#47760 (comment)
#13161 (comment)
@hauntsaninja hauntsaninja self-assigned this Jul 20, 2022
@hauntsaninja
Copy link
Collaborator Author

Improve interaction between --ignore-missing-stub and typos: pandas-dev/pandas#47760 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hauntsaninja hauntsaninja

Labels
feature topic-stubtest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hauntsaninja