Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit non-dir items when constructing a NamespaceReader #315

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Omit non-dir items when constructing a NamespaceReader #315

merged 2 commits into from
Sep 9, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Aug 20, 2024 •
edited
Loading

Closes #311

  • Add test capturing failure when resolving the MultiplexedPath for a namespace package with non-path elements in the path.
  • Omit sentinel values from a namespace path.

@jaraco jaraco force-pushed the bugfix/311-non-path-namespace-paths branch from ae4b882 to c9a1aae Compare August 20, 2024 16:14
@jaraco jaraco requested a review from FFY00 August 20, 2024 16:26
@jaraco
Add test capturing failure when resolving the MultiplexedPath for a n…
47d73b1 
…amespace package with non-path elements in the path.

Ref #311
@jaraco
Omit sentinel values from a namespace path.
2c145c5 
When editable installs create sentinels, as they are not a valid directory, they're unsuitable for constructing a `MultiplexedPath`. Filter them out.

Fixes #311
@jaraco jaraco force-pushed the bugfix/311-non-path-namespace-paths branch from c9a1aae to 2c145c5 Compare September 9, 2024 16:56
@jaraco jaraco merged commit 63a7bcb into main Sep 9, 2024
28 checks passed
@jaraco jaraco deleted the bugfix/311-non-path-namespace-paths branch September 9, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal left review comments

@FFY00 FFY00 Awaiting requested review from FFY00

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calling importlib_resources.files with an editable install fails
2 participants
@jaraco @pablogsal