Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review bpo-15871: Online docs: make index search always available. #39

Closed
iritkatriel opened this issue Mar 28, 2022 · 9 comments
Closed

Comments

@iritkatriel
Copy link
Member

An old open issue that you may be able to resolve.

@CAM-Gerlach
Copy link
Member

The current "Quick Search" seems to be fairly effective in using and prioritizing index hits, such that (if I'm not just using google) it almost always seems to find what I'm looking for (and thus I was not able to duplicate the poor results suggested by the earlier comments in the BPO issue). A realtime search using only the index popping up results as users type in the search box would be useful, but it seems non-trivial to implement especially if the plan is to move to a more modern docs theme.

@pradyunsg Is there any plan for Furo to offer something like this?

@pradyunsg
Copy link
Member

pradyunsg commented Apr 1, 2022

@pradyunsg Is there any plan for Furo to offer something like this?

No.

I empathise and agree that would be a significantly better UX -- I don't think a Sphinx theme is the correct place to completely rework how Sphinx's search works though. :)


I'm not quite sure what that issue is about, and how that would be related to a Sphinx theme that Python's documentation does not even use.

The b.p.o issue seems to be start by describing Windows Help, but also mentions things like bad search results on the online site (I can't reproduce the report in https://bugs.python.org/issue15871#msg170048 -- https://docs.python.org/3/search.html?q=random, but others do provide suboptimal results -- https://docs.python.org/3/search.html?q=if).

Anyway, based on what I'm reading in that b.p.o issue, I think what's actionable here is more along the lines of "improve search results" rather than "rework what the search UX is".

@CAM-Gerlach
Copy link
Member

how that would be related to a Sphinx theme that Python's documentation does not even use.

Sorry, I was just curious if you had experience with or input on this, and I thought there was at least a tentative proposal to move CPython's docs to a more modern theme, which might have been able to address this.

@encukou encukou changed the title Review bpo-15871: Online docs: make index search always available. Review bpo-15871: Windows Help docs: make index search always available. Apr 4, 2022
@encukou encukou changed the title Review bpo-15871: Windows Help docs: make index search always available. Review bpo-15871: Online docs: make index search always available. Apr 4, 2022
@encukou
Copy link
Member

encukou commented Apr 4, 2022

Oh, this is about docs.python.org, which is lacking compared to the CHM version of the docs. Sorry for changing the title.

The issue seems to have been mostly solved in Sphinx 1.2 (2013): sphinx-doc/sphinx#1067

@encukou
Copy link
Member

encukou commented Apr 4, 2022

Hm, I can replicate the bad results mentioned in the 2014 comments -- for print and with.

@encukou
Copy link
Member

encukou commented Apr 4, 2022

Also, coming from #42: searching for symbols like / should yield the correct docs.

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Apr 16, 2022

See #44 for some additional directly related discussion, might be worth closing one of these as a duplicate

@pradyunsg
Copy link
Member

x-ref: python/cpython#60075

@AA-Turner
Copy link
Member

This is now python/cpython#60075, discussion should happen on that issue as noted in the May 2022 meeting.

A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants