-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93649: Split memory and docstring tests from _testcapimodule.c #99517
gh-93649: Split memory and docstring tests from _testcapimodule.c #99517
Conversation
erlend-aasland
commented
Nov 15, 2022
- Split up _testcapimodule.c #93649: Split docstring from _testcapimodule.c
- Split up _testcapimodule.c #93649: Splic memory tests from _testcapimodule.c
Should we also add the three tracemalloc tests to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I suggest to rename "mem.c" to "pymem.c", since most tests are about the "PyMem" API: https://docs.python.org/dev/c-api/memory.html
But I'm also fine with "mem" name, it's up to you.
I think I prefer the "mem" name, but I'm not sure it matters much really. What do you think about including the tracemalloc tests? |
We can add the tracemalloc tests later if we find out they should live in |
|
@erlend-aasland can you please review my fix of this failure? It happens for each PR right now :( Link: #99519 |
Yep, it makes sense to move them in mem.c. |