-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-92446: Fix Argparse and LZMACompressor Docs #94627
Changes from 5 commits
3e55685
956df83
3c512f1
7ce0990
917d4e9
0e96c38
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,7 +147,7 @@ Compressing and decompressing data in memory | |
This format is more limited than ``.xz`` -- it does not support integrity | ||
checks or multiple filters. | ||
|
||
* :const:`FORMAT_RAW`: A raw data stream, not using sequences format. | ||
* :const:`FORMAT_RAW`: A raw data stream, not using any container format. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't know what the motivation is for this change, and it doesn't seem related to the linked issue. Why is it needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was (seemingly) mistakenly changed in https://github.com/python/cpython/pull/92450/files , a previous attempt to fix the issue |
||
This format specifier does not support integrity checks, and requires that | ||
you always specify a custom filter chain (for both compression and | ||
decompression). Additionally, data compressed in this manner cannot be | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sets are not sequences, so this sentence doesn't make sense any more. @rhettinger wrote on the issue that sets don't work well, so I suggest we mention tuples as a second example here instead of sets.