Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126699: allow AsyncIterator to be used as a base for Protocols #126702

Merged
merged 2 commits into from
Nov 12, 2024
Merged

gh-126699: allow AsyncIterator to be used as a base for Protocols #126702

merged 2 commits into from
Nov 12, 2024

Conversation

tungol
Copy link
Contributor

@tungol tungol commented Nov 11, 2024 •
edited by bedevere-app bot
Loading

AsyncIterator was removed from _PROTO_ALLOWLIST by #15647, without any discussion. It looks like an accident to me. This restores it to the list.

@bedevere-app bedevere-app bot mentioned this pull request Nov 11, 2024
Closed
@AlexWaygood AlexWaygood merged commit feb3e0b into python:main Nov 12, 2024
40 checks passed
@AlexWaygood
Copy link
Member

Backport? To me this feels like a bug; I don't think it should ever have been removed from the allowlist

@tungol tungol deleted the AsyncIterator branch November 12, 2024 10:02
@ZeroIntensity ZeroIntensity added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
@miss-islington-app
Copy link

Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@AlexWaygood
Copy link
Member

Thanks @ZeroIntensity. For the future: I was hoping to give the other people on this PR thread a chance to object before adding the backport labels, or I would have done so myself. It's only 7:20am where Jelle is right now :-)

@ZeroIntensity
Copy link
Member

Good to know :)

As a side note, is the bot sick? Those backport are taking a while.

@AlexWaygood
Copy link
Member

I think she may be feeling poorly today, yeah -- there's some discussion on Discord about it

@ambv ambv added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 12, 2024
@miss-islington-app
Copy link

Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @tungol for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@tungol @miss-islington
pythongh-126699: allow AsyncIterator to be used as a base for Protoco…
a38877b 
…ls (pythonGH-126702)

(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126761 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 12, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 12, 2024
@tungol @miss-islington
pythongh-126699: allow AsyncIterator to be used as a base for Protoco…
0e45a7a 
…ls (pythonGH-126702)

(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 12, 2024

GH-126762 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 12, 2024
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @tungol
[3.13] gh-126699: allow AsyncIterator to be used as a base for Protoc…
a5672be 
…ols (GH-126702) (#126762)

gh-126699: allow AsyncIterator to be used as a base for Protocols (GH-126702)
(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton <[email protected]>
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @tungol
[3.12] gh-126699: allow AsyncIterator to be used as a base for Protoc…
34137cb 
…ols (GH-126702) (#126761)

gh-126699: allow AsyncIterator to be used as a base for Protocols (GH-126702)
(cherry picked from commit feb3e0b)

Co-authored-by: Stephen Morton <[email protected]>
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@tungol @picnixz
pythongh-126699: allow AsyncIterator to be used as a base for Protoco…
28fb3b0 
…ls (python#126702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@asvetlov asvetlov asvetlov approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tungol @AlexWaygood @ZeroIntensity @asvetlov @JelleZijlstra @sobolevn @ambv