gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

longvhdeveloper · 2023-02-21T07:25:10Z

Issue: HTTPError fp.read returns string instead of bytes #101936

cpython-cla-bot · 2023-02-21T07:25:35Z

All commit authors signed the Contributor License Agreement.

corona10

Please update the test to following codeline.

Lines 1827 to 1830 in 6f25657

    
           def test_gh_98778(self): 
        
               x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None) 
        
               self.assertEqual(getattr(x, "__notes__", ()), ())

corona10 · 2023-02-21T07:38:28Z

Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst

@@ -0,0 +1 @@
+HTTPError fp.read returns string instead of bytes


The default value of ``fp`` becomes :class:`io.BytesIO` if :exc:`~urllib.error.HTTPError` is initialized without a designated `fp` parameter. Patch by Long Vo.

bedevere-bot · 2023-02-21T07:40:41Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

corona10

Almost come :)

corona10 · 2023-02-21T11:14:00Z

Misc/NEWS.d/next/Library/2023-02-21-07-48-03.gh-issue-101936.xPawo7.rst

+The default value of fp becomes :class:io.BytesIO if
+:exc:~urllib.error.HTTPError is initialized without a designated fp


Suggested change

The default value of fp becomes :class:io.BytesIO if

:exc:~urllib.error.HTTPError is initialized without a designated fp

The default value of fp becomes :class:`io.BytesIO` if

:exc:`~urllib.error.HTTPError` is initialized without a designated ``fp``

corona10 · 2023-02-21T11:15:11Z

Lib/test/test_urllib2.py

@@ -1827,6 +1827,7 @@ def test_HTTPError_interface(self):
    def test_gh_98778(self):
        x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None)
        self.assertEqual(getattr(x, "__notes__", ()), ())
+        self.assertEqual(isinstance(x.fp.read(), bytes), True)


Suggested change

self.assertEqual(isinstance(x.fp.read(), bytes), True)

self.assertIsInstance(x.fp.read(), bytes)

Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst

…VOxHH.rst

Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst

…VOxHH.rst

corona10

lgtm

miss-islington · 2023-02-21T15:14:45Z

Thanks @longvhdeveloper for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…o.BytesIO (pythongh-102100) (cherry picked from commit 0d4c7fc) Co-authored-by: Vo Hoang Long <[email protected]> Co-authored-by: Long Vo <[email protected]>

bedevere-bot · 2023-02-21T15:14:55Z

GH-102117 is a backport of this pull request to the 3.11 branch.

…o.BytesIO (pythongh-102100) (cherry picked from commit 0d4c7fc) Co-authored-by: Vo Hoang Long <[email protected]> Co-authored-by: Long Vo <[email protected]>

bedevere-bot · 2023-02-21T15:15:16Z

GH-102118 is a backport of this pull request to the 3.10 branch.

…io.BytesIO (gh-102100) (gh-102117) gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100) (cherry picked from commit 0d4c7fc) Co-authored-by: Long Vo <[email protected]>

…io.BytesIO (gh-102100) (#102118) gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100) (cherry picked from commit 0d4c7fc) Co-authored-by: Long Vo <[email protected]>

* main: (76 commits) Fix syntax error in struct doc example (python#102160) pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089) pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143) Few coverage nitpicks for the cmath module (python#102067) pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985) pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137) pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356) pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119) pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100) pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009) pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923) pythongh-100556: Improve clarity of `or` docs (python#100589) pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026) pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966) pythongh-101578: Amend exception docs (python#102057) pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068) pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078) pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012) pythongh-101566: Sync with zipp 3.14. (pythonGH-102018) pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589) ...

…o.BytesIO (pythongh-102100) Co-authored-by: Long Vo <[email protected]>

HTTPError fp.read returns string instead of bytes

5042916

bedevere-bot added the awaiting review label Feb 21, 2023

bedevere-bot mentioned this pull request Feb 21, 2023

HTTPError fp.read returns string instead of bytes #101936

Closed

corona10 self-assigned this Feb 21, 2023

corona10 self-requested a review February 21, 2023 07:33

corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 21, 2023

corona10 requested changes Feb 21, 2023

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting review labels Feb 21, 2023

corona10 changed the title ~~gh-101936: HTTPError fp.read returns string instead of bytes~~ gh-101936: Update the default value of fp from io.StringIO to io.BytesIO Feb 21, 2023

update unit test

3553029

corona10 requested changes Feb 21, 2023

View reviewed changes

longvhdeveloper added 3 commits February 21, 2023 13:41

Update Misc/News.d

1de16a7

update unit test

d5b74b6

Update Misc/NEWS.d

b02433e

corona10 reviewed Feb 21, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.Q…

9cc1605

…VOxHH.rst

corona10 reviewed Feb 21, 2023

View reviewed changes

Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.QVOxHH.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2023-02-21-07-15-41.gh-issue-101936.Q…

b1c8dea

…VOxHH.rst

corona10 approved these changes Feb 21, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels Feb 21, 2023

corona10 merged commit 0d4c7fc into python:main Feb 21, 2023

bedevere-bot removed the awaiting merge label Feb 21, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 21, 2023

bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 21, 2023

python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024

pythongh-101936: Update the default value of fp from io.StringIO to i…

563bb72

…o.BytesIO (pythongh-102100) Co-authored-by: Long Vo <[email protected]>

python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024

pythongh-101936: Update the default value of fp from io.StringIO to i…

4f88406

…o.BytesIO (pythongh-102100) Co-authored-by: Long Vo <[email protected]>

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024

pythongh-101936: Update the default value of fp from io.StringIO to i…

c1a279c

…o.BytesIO (pythongh-102100) Co-authored-by: Long Vo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

longvhdeveloper commented Feb 21, 2023 •

edited by bedevere-bot

Loading

cpython-cla-bot bot commented Feb 21, 2023 •

edited

Loading

corona10 left a comment

corona10 Feb 21, 2023 •

edited

Loading

bedevere-bot commented Feb 21, 2023

corona10 left a comment

corona10 Feb 21, 2023

corona10 Feb 21, 2023

corona10 left a comment

miss-islington commented Feb 21, 2023

bedevere-bot commented Feb 21, 2023

bedevere-bot commented Feb 21, 2023

	def test_gh_98778(self):
	x = urllib.error.HTTPError("url", 405, "METHOD NOT ALLOWED", None, None)
	self.assertEqual(getattr(x, "__notes__", ()), ())

		@@ -0,0 +1 @@
		HTTPError fp.read returns string instead of bytes

		The default value of fp becomes :class:io.BytesIO if
		:exc:~urllib.error.HTTPError is initialized without a designated fp

	self.assertEqual(isinstance(x.fp.read(), bytes), True)
	self.assertIsInstance(x.fp.read(), bytes)

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100

Conversation

longvhdeveloper commented Feb 21, 2023 • edited by bedevere-bot Loading

cpython-cla-bot bot commented Feb 21, 2023 • edited Loading

corona10 left a comment

Choose a reason for hiding this comment

corona10 Feb 21, 2023 • edited Loading

Choose a reason for hiding this comment

bedevere-bot commented Feb 21, 2023

corona10 left a comment

Choose a reason for hiding this comment

corona10 Feb 21, 2023

Choose a reason for hiding this comment

corona10 Feb 21, 2023

Choose a reason for hiding this comment

corona10 left a comment

Choose a reason for hiding this comment

miss-islington commented Feb 21, 2023

bedevere-bot commented Feb 21, 2023

bedevere-bot commented Feb 21, 2023

longvhdeveloper commented Feb 21, 2023 •

edited by bedevere-bot

Loading

cpython-cla-bot bot commented Feb 21, 2023 •

edited

Loading

corona10 Feb 21, 2023 •

edited

Loading