Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-98831: rewrite pattern matching opcodes in the instruction definition DSL #101287

Merged
merged 5 commits into from
Jan 24, 2023
Merged

gh-98831: rewrite pattern matching opcodes in the instruction definition DSL #101287

merged 5 commits into from
Jan 24, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Jan 24, 2023 •
edited by bedevere-bot
Loading

Separated these out for @brandtbucher to review.

@bedevere-bot bedevere-bot mentioned this pull request Jan 24, 2023
Closed
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jan 24, 2023
brandtbucher
brandtbucher approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One tiny comment:

Python/bytecodes.c Outdated Show resolved Hide resolved
gvanrossum
gvanrossum reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but agree with Brandt's suggestion.

gvanrossum
gvanrossum approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@iritkatriel iritkatriel merged commit 1a9d8c7 into python:main Jan 24, 2023
@iritkatriel iritkatriel deleted the bytecodes branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @gvanrossum @brandtbucher @bedevere-bot