-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Official Windows installers are not interoperable with those built locally with Tools\msi\buildrelease.bat #96729
Comments
Agreed, this one should not have changed, and should be changed back. The use of a URI here is to allow alternative distributors to have an easy way to choose what their discriminator should be. Arguably, the motivating use case here should be using a different URI from python.org releases anyway, but provided it's for private use only I don't really have a concern. |
Maybe when changing it back, add a comment, so that the next person to run a regex for issues knows not to change it. |
…at have matching UUIDs with official releases (pythonGH-96755) (cherry picked from commit 662782e) Co-authored-by: adang1345 <[email protected]>
…e matching UUIDs with official releases (GH-96755)
…at have matching UUIDs with official releases (pythonGH-96755) (cherry picked from commit 662782e) Co-authored-by: adang1345 <[email protected]>
Thanks for the fix! |
…e matching UUIDs with official releases (GH-96755) (cherry picked from commit 662782e) Co-authored-by: adang1345 <[email protected]>
…e matching UUIDs with official releases (GH-96755) (cherry picked from commit 662782e) Co-authored-by: adang1345 <[email protected]>
…e matching UUIDs with official releases (GH-96755) (cherry picked from commit 662782e) Co-authored-by: adang1345 <[email protected]>
Bug report
For some of my projects, I build my own Windows installers from source using the
Tools\msi\buildrelease.bat
script. For Python 3.9.7 and higher, the installers I build locally are no longer interoperable with those that are released officially. For example, if I have an official Python 3.9.13 installation, I can't upgrade it using a locally-built Python 3.9.14 installer. My locally-built installer does not recognize that there already exists a 3.9.x installation that can be upgraded, and it asks me to do a completely new installation.I traced the cause of this to #27458, which first appeared in Python 3.9.7. In particular, in the file
Tools\msi\buildrelease.bat
, the linewas changed to
However, based on my understanding, official releases still use the value
http://www.python.org/{arch}
, as evidenced by the linein https://github.com/python/release-tools/blob/master/windows-release/stage-msi.yml
The
RELEASE_URI
affects the GUIDs of the installers so that installers built with differentRELEASE_URI
values cannot be used to upgrade each other.For the sake of consistency, I propose that we change
RELEASE_URI
inTools\msi\buildrelease.bat
back to its original value ofhttp://www.python.org/{arch}
. I tried making this change locally, and that fixed my interoperability issue. I can make a pull request as well.Your environment
(originally posted on https://discuss.python.org/t/divergence-between-official-releases-and-those-built-with-tools-msi-buildrelease-bat/18927)
The text was updated successfully, but these errors were encountered: