Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose _NamespacePath #119668

Open
FFY00 opened this issue May 28, 2024 · 3 comments
Open

Expose _NamespacePath #119668

FFY00 opened this issue May 28, 2024 · 3 comments
Labels
type-feature A feature request or enhancement

Comments

@FFY00
Copy link
Member

FFY00 commented May 28, 2024

Feature or enhancement

Proposal:

Currently, _NamespacePath is prefixed as a private type, but since it's exposed, it should be marked as public API. I have a specific case in mind where I want to do an instance check.

I vaguely remember a discussion somewhere with @warsaw where this was mentioned, but I can't find it.

Has this already been discussed elsewhere?

This is a minor feature, which does not need previous discussion elsewhere

Links to previous discussion of this feature:

No response

Linked PRs

@FFY00 FFY00 added the type-feature A feature request or enhancement label May 28, 2024
FFY00 added a commit to FFY00/cpython that referenced this issue May 28, 2024
@warsaw
Copy link
Member

warsaw commented May 28, 2024

I'll have to look around to see if I can dig up the previous discussion, but +1!

@ericvsmith
Copy link
Member

I don't think we thought it should be hidden, rather there was just no reason to expose it. What's the need for accessing it? If it's at all compelling, then I'm +1.

@FFY00
Copy link
Member Author

FFY00 commented May 30, 2024

For my specific case, I am loading data from a namespace package, or rather, I need to point to the directories containing said data. This could also be solved by importlib.resources in MultiplexedPath, I have opened python/importlib_resources#309 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants