Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like there's bugs in both mypy and pylint with regards to the
__eq__
in Statement in flake8_trio.py (nobody mentions NamedTuple in python/mypy#6910 - but I think it's the same?), and while the pylint issue pylint-dev/pylint#225 is closed it's cropping up incheckpoint_continue/break
as well.But with 11 disabled flags flake8_trio and tests/test* now pass without any errors - though if pylint was added to tox a few of those would probably be
#pylint: disable=XXX
instead.I elected to explicitly set encoding in all opens as well, according to https://peps.python.org/pep-0597/
I also wiped a redundant test after running
pylint --disable=all --enable=similarities tests/trio*
- but that also gives a bunch of false positives. Though I am tempted to merge 103&104, and instead of doing#error:
to mark errors do#TRIO\d\d\d:
. I think this would also allow more#INCLUDE
(or rather, change it to#EXCLUDE
and only use that when necessary) and that might catch more stuff that's missing an explicit check.