Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pylint pass #30

Merged
merged 2 commits into from
Aug 10, 2022
Merged

pylint pass #30

merged 2 commits into from
Aug 10, 2022

Conversation

jakkdl
Copy link
Member

@jakkdl jakkdl commented Aug 9, 2022

Looks like there's bugs in both mypy and pylint with regards to the __eq__ in Statement in flake8_trio.py (nobody mentions NamedTuple in python/mypy#6910 - but I think it's the same?), and while the pylint issue pylint-dev/pylint#225 is closed it's cropping up in checkpoint_continue/break as well.
But with 11 disabled flags flake8_trio and tests/test* now pass without any errors - though if pylint was added to tox a few of those would probably be #pylint: disable=XXX instead.

I elected to explicitly set encoding in all opens as well, according to https://peps.python.org/pep-0597/

I also wiped a redundant test after running pylint --disable=all --enable=similarities tests/trio* - but that also gives a bunch of false positives. Though I am tempted to merge 103&104, and instead of doing #error: to mark errors do #TRIO\d\d\d:. I think this would also allow more #INCLUDE (or rather, change it to #EXCLUDE and only use that when necessary) and that might catch more stuff that's missing an explicit check.

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks reasonable to me, but let's not bother with further changes; it doesn't add much value and we're nearly done anyway.

@Zac-HD Zac-HD merged commit e0f77a7 into python-trio:main Aug 10, 2022
@jakkdl
Copy link
Member Author

jakkdl commented Aug 10, 2022

makes sense, I'll just run pylint locally then to catch any bugs while developing 👍

@jakkdl jakkdl deleted the code_cleanup branch August 23, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants