Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a logger and verbosity options #168

Closed
KevinHock opened this issue Aug 23, 2018 · 3 comments
Closed

Add a logger and verbosity options #168

KevinHock opened this issue Aug 23, 2018 · 3 comments
Labels
good first issue help wanted important

Comments

@KevinHock
Copy link
Collaborator

So after #99 is merged, we will be be pretty accurate, accurate enough for us to shift our focus towards making the tool more resilient and able to run on lots and lots of repos.

PyT needs to be more user-friendly by letting the user know e.g. which files it is looking at, and also more resilient, logging will help with fixing issues like RecursionDepth errors etc.

Here is a logging PR that is pretty good we can take things from Yelp/detect-secrets#46
@KevinHock
Copy link
Collaborator Author

Hi @bcaller, sorry I wasn't on Slack for a long time, I got back to you 👍

@bcaller
Copy link
Collaborator

bcaller commented Sep 12, 2018

Initial logging framework added in #172.

@KevinHock
Copy link
Collaborator Author

Good point, I forgot to close 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted important
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KevinHock @bcaller