Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env: rename "system" to "base" in output of env info #8832

Merged
merged 2 commits into from
Jan 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/managing-environments.md
Original file line number Diff line number Diff line change
Expand Up @@ -88,13 +88,13 @@ poetry env info
will output something similar to this:

```text
Virtual environment
Virtualenv
Python: 3.7.1
Implementation: CPython
Path: /path/to/poetry/cache/virtualenvs/test-O3eWbxRl-py3.7
Valid: True

System
Base
Platform: darwin
OS: posix
Python: /path/to/main/python
Expand Down
10 changes: 5 additions & 5 deletions src/poetry/console/commands/env/info.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,15 @@ def _display_complete_info(self, env: Env) -> None:

self.line("")

system_env = env.parent_env
python = ".".join(str(v) for v in system_env.version_info[:3])
self.line("<b>System</b>")
base_env = env.parent_env
python = ".".join(str(v) for v in base_env.version_info[:3])
self.line("<b>Base</b>")
self.line(
"\n".join([
f"<info>Platform</info>: <comment>{env.platform}</>",
f"<info>OS</info>: <comment>{env.os}</>",
f"<info>Python</info>: <comment>{python}</>",
f"<info>Path</info>: <comment>{system_env.path}</>",
f"<info>Executable</info>: <comment>{system_env.python}</>",
f"<info>Path</info>: <comment>{base_env.path}</>",
f"<info>Executable</info>: <comment>{base_env.python}</>",
])
)
2 changes: 1 addition & 1 deletion tests/console/commands/env/test_info.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_env_info_displays_complete_info(tester: CommandTester) -> None:
Executable: {sys.executable}
Valid: True

System
Base
Platform: darwin
OS: posix
Python: {'.'.join(str(v) for v in sys.version_info[:3])}
Expand Down