Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running poetry --help gives the behaviour of poetry list --help instead of poetry list #8710

Closed
4 tasks done
MaddyGuthridge opened this issue Nov 25, 2023 · 6 comments
Closed
4 tasks done
Labels
kind/bug Something isn't working as expected

Comments

@MaddyGuthridge
Copy link

  • Poetry version: 1.7.1
  • Python version: 3.11
  • OS version and name: Fedora Linux 38
  • pyproject.toml: N/A
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

A common design for console applications is to give general help for using the command if the command is run with a --help flag. Some (including Poetry) also give this same output when running the command without arguments. Poetry (seemingly) accomplishes this by aliasing poetry to be equivalent to poetry list.

However, a confusing side effect of this is that running poetry --help is the equivalent to poetry list --help. Given that users who run poetry --help likely want to learn about the available commands within Poetry, this behaviour is likely not the best design, since it creates additional work for users. Every time I forget the correct commands to use when working on a project with Poetry, I run poetry --help, only to need to remind myself of this behaviour and run poetry, which is a little frustrating.

To be clear, this isn't a major issue, but I think that quality-of-life improvements such as this contribute significantly to the developer experience, so some attention to detail wouldn't go astray.

@MaddyGuthridge MaddyGuthridge added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Nov 25, 2023
@dimbleby
Copy link
Contributor

Submit a merge request!

@MaddyGuthridge
Copy link
Author

I'll definitely give it a go if I have time - it's been added to my (exceedingly long) todo list

@fczuardi
Copy link

Do you have some pointer on where to look in the code to know what part deals with the "--help"? Is it on the poetry source code? Or on the cleo source code?

@Secrus
Copy link
Member

Secrus commented Nov 30, 2023

Do you have some pointer on where to look in the code to know what part deals with the "--help"? Is it on the poetry source code? Or on the cleo source code?

This is in Cleo repo and there is already python-poetry/cleo#249. It's non-trivial to tackle, but will be fixed in Cleo 3.0, which I am working on currently.

@Secrus Secrus closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
@Secrus
Copy link
Member

Secrus commented Nov 30, 2023

Do you have some pointer on where to look in the code to know what part deals with the "--help"? Is it on the poetry source code? Or on the cleo source code?

This is in Cleo repo and there is already python-poetry/cleo#249. It's non-trivial to tackle, but will be fixed in Cleo 3.0, which I am working on currently.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
@abn abn removed the status/triage This issue needs to be triaged label Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

5 participants