Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry-core 1.3.1 + pypa/build 0.8.0 fails to build package contains "-" in its name #6733

Closed
4 tasks done
ymyzk opened this issue Oct 7, 2022 · 4 comments · Fixed by python-poetry/poetry-core#495
Closed
4 tasks done
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged

Comments

@ymyzk
Copy link

ymyzk commented Oct 7, 2022

  • Poetry version:
Poetry (version 1.2.1)

poetry==1.2.1 and poetry-core==1.3.1

  • Python version:
Poetry
Version: 1.2.1
Python:  3.10.7

Virtualenv
Python:         3.10.7
Implementation: CPython
Path:           /home/yusuke/Downloads/poetry-bug-report/venv
Executable:     /home/yusuke/Downloads/poetry-bug-report/venv/bin/python
Valid:          True

System
Platform:   linux
OS:         posix
Python:     3.10.7
Path:       /usr
Executable: /usr/bin/python3.10
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

We can run the following steps to reproduce the issue.

$ git clone [email protected]:ymyzk/poetry-bug-report.git
$ cd poetry-bug-report
$ python -m build
* Creating virtualenv isolated environment...
* Installing packages in isolated environment... (poetry-core==1.3.1)
* Getting dependencies for sdist...
* Building sdist...
ERROR Source /tmp/build-via-sdist-1cju5o9a/poetry_bug_report-0.1.0 is not a directory

Poetry should be using /tmp/build-via-sdist-1cju5o9a/poetry-bug-report-0.1.0 instead.

It seems poetry-core 1.3.1 fails to build a package which has - in its name.

  • This issue won't happening with poetry-core 1.2.0.
  • This issue won't happen with poetry build.
  • This issue won't happen if we replace - in the package name with _.
@ymyzk ymyzk added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Oct 7, 2022
@neersighted
Copy link
Member

PTAL @dimbleby

@dimbleby
Copy link
Contributor

dimbleby commented Oct 7, 2022

want to use the escaped name here presumably

@ymyzk
Copy link
Author

ymyzk commented Oct 8, 2022

Thank you @dimbleby and @neersighted for releasing a fix quickly. I also confirmed that poetry-core==1.3.2 fixed the issue here.

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected status/triage This issue needs to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants