Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install pyproject.toml packages as path dependencies #5965

Closed
3 tasks done
CLOVIS-AI opened this issue Jul 7, 2022 · 5 comments
Closed
3 tasks done

Cannot install pyproject.toml packages as path dependencies #5965

CLOVIS-AI opened this issue Jul 7, 2022 · 5 comments
Labels
kind/bug Something isn't working as expected

Comments

@CLOVIS-AI
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
  • OS version and name: ArchLinux
  • Poetry version: 1.1.13

Issue

A Rust extension managed by Maturin has a pyproject.toml file with build-system.requires properly set to compile and package the Rust code.

Installing such a package is as simple as pip install <path-to-package>.

When added as a path dependency in a Poetry project: project = { path = "../project", develop = false }, poetry update fails with:
Directory /home/[REDACTED]/project does not seem to be a Python package

poetry/core/packages/directory_dependency.py:53 accepts dependencies that are either a Poetry pyproject.toml, or have a setup.py file. pyproject.toml is a standard Python packaging file, and Poetry should accept installing a non-Poetry project that uses this format.

@CLOVIS-AI CLOVIS-AI added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jul 7, 2022
@dimbleby
Copy link
Contributor

dimbleby commented Jul 7, 2022

duplicate #5655, apparently fixed by python-poetry/poetry-core#368

I've lost track of what's in the latest beta, you may need to wait for the next release to verify.

@finswimmer
Copy link
Member

Duplicate of #5655

@finswimmer finswimmer marked this as a duplicate of #5655 Jul 8, 2022
@CLOVIS-AI
Copy link
Author

Do you have an estimate of when that will be?

@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Jul 9, 2022
@Telofy
Copy link

Telofy commented Feb 9, 2024

In case someone finds this searching for “does not seem to be a Python package”: The pyproject.toml of the dependency has to have a build-system section to be considered valid. E.g.:

[build-system]
requires = ["setuptools", "wheel"]

I'm guessing this is about to be fixed in the next release through this commit.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

5 participants