Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry doesn't recognize setuptools based project if it has no setup.py (only setup.cfg) #5692

Closed
3 tasks done
fmagin opened this issue May 26, 2022 · 3 comments · Fixed by python-poetry/poetry-core#368
Closed
3 tasks done
Labels
area/core Related to the poetry-core library kind/bug Something isn't working as expected

Comments

@fmagin
Copy link

fmagin commented May 26, 2022

Issue

the angr project has various subprojects that only have a setup.cfg file and no setup.py file. This results in poetry throwing an exception when trying to use them as a local path package: i.e. Directory /home/fmagin/Projects/angr-dev/archinfo does not seem to be a Python package. in poetry/core/packages/directory_dependency.py:54. Specifically this happens because the check only checks if a setup.py exists or if the pyproject.toml has tool.poetry keys. Both aren't true for the angr subprojects. If I edit the poetry source code and add a check for the existence of setup.cfg file then poetry works as expected (and like if I had specified the dependency as a pinned git commit from GitHub directly), so I am considering this a bug

@fmagin fmagin added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels May 26, 2022
@abn
Copy link
Member

abn commented May 26, 2022

@fmagin can you try the fix at python-poetry/poetry-core#368 (comment) please?

@abn abn added area/core Related to the poetry-core library and removed status/triage This issue needs to be triaged labels May 26, 2022
@fmagin
Copy link
Author

fmagin commented May 26, 2022

@abn yep that fix works! I searched the previous issues for setup.cfg and didn't find any, so I didn't realize there was such a recent issue/PR for this already

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core Related to the poetry-core library kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants