Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry install localstack['runtime'] fails #5217

Closed
3 tasks done
orientalperil opened this issue Feb 18, 2022 · 7 comments
Closed
3 tasks done

Poetry install localstack['runtime'] fails #5217

orientalperil opened this issue Feb 18, 2022 · 7 comments
Labels
area/solver Related to the dependency resolver kind/bug Something isn't working as expected

Comments

@orientalperil
Copy link

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

Poetry runs dependency resolver forever when I run poetry add localstack['runtime']

@orientalperil orientalperil added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Feb 18, 2022
@dimbleby
Copy link
Contributor

It looks as though poetry's first attempt at a solution is in some way incompatible with awscli - and that it sits there working through the many hundreds of versions of awscli, failing to find one that is compatible. This seems to cause it to build up such a huge number of constraints that it kinda grinds to a halt.

I was able to get to a solution in reasonable time by first adding an explicit dependency on a recent awscli, that seems to be enough to send poetry down a path that's not a dead end. However that also ran into #4683...

@abn abn added area/solver Related to the dependency resolver and removed status/triage This issue needs to be triaged labels Apr 8, 2022
@abn
Copy link
Member

abn commented Apr 8, 2022

Resolved by #5335

@abn abn closed this as completed Apr 8, 2022
@dimbleby
Copy link
Contributor

dimbleby commented Apr 8, 2022

This is not resolved by #5335 - that MR improves things, but still localstack['runtime'] is uninstallable without hints about picking a recent awscli

@abn
Copy link
Member

abn commented Apr 9, 2022

I think the fix here is to constrain awscli together with the PR to get a more reasonable solving time. The add did succeed for me after an hour or so. :(

Doubt these cases will ever be improved with the metadata currently available.

@dimbleby
Copy link
Contributor

it's not really about the metadata (though it does help when that is available). As best I recall from when I looked at this at #5335-time, we end up building Term objects with massively elaborate constraints, and then operations to compare those constraints become expensive. It's 100% CPU-bound computation that is the bottleneck, not downloading and inspecting wheels.

I don't have great ideas about how to reorganise the data structures to fix this and you may be right that it will never get improved. I might or might not have another think about it some day...

Personally I'd have left this open so that we acknowledge that it's still a problem, and maybe someone else will see it and feel like doing something about it. But no big deal I guess.

@abn
Copy link
Member

abn commented Apr 10, 2022

I agree that this will need to be looked at in more detail. My recommendation there would be to open a new issue specific for this class of issue with the solver. Atleast, this way people who get to this issue with the same package has a clear mitigation and a link to a more deeper dive issue.

Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/solver Related to the dependency resolver kind/bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants