Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry show and poetry install should throw an error when used with an unknown group name #4576

Closed
3 tasks done
pmav99 opened this issue Sep 30, 2021 · 2 comments
Closed
3 tasks done
Labels
area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling area/ux Features and improvements related to the user experience

Comments

@pmav99
Copy link
Contributor

pmav99 commented Sep 30, 2021

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).
poetry debug info

Poetry
Version: 1.2.0a2
Python:  3.9.7

Virtualenv
Python:         3.8.12
Implementation: CPython
Path:           /tmp/aaa/.venv
Valid:          True

System
Platform: linux
OS:       posix
Python:   /usr

Issue

Specifying an unknown group name on poetry show and poetry install (and possibly other commands that handle dependency groups) results in no error whatsoever. E.g.

poetry show --without gibberish && echo OK
poetry show --with gibberish && echo OK

poetry install --without gibberish && echo OK
poetry install --with gibberish && echo OK

IMHV, unknown group names, at least most of the time, imply typos and should result in an error.

The same happens e.g. in the export plugin, but I will open a separate issue there.

@pmav99 pmav99 added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Sep 30, 2021
@pmav99 pmav99 changed the title poetry show should throw an error when used with an unknown group name poetry show and poetry install should throw an error when used with an unknown group name Sep 30, 2021
@finswimmer finswimmer added area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling area/ux Features and improvements related to the user experience and removed kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Dec 28, 2021
@ralbertazzi
Copy link
Contributor

Duplicate of #7303, which has been fixed

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Related to the command line area/error-handling Bad error messages/insufficient error handling area/ux Features and improvements related to the user experience
Projects
None yet
Development

No branches or pull requests

3 participants