Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry silently skips installing "extras" that aren't lowercase #4123

Closed
3 tasks done
deepyaman opened this issue Jun 1, 2021 · 1 comment · Fixed by #4122
Closed
3 tasks done

Poetry silently skips installing "extras" that aren't lowercase #4123

deepyaman opened this issue Jun 1, 2021 · 1 comment · Fixed by #4122
Labels
kind/bug Something isn't working as expected

Comments

@deepyaman
Copy link
Contributor

deepyaman commented Jun 1, 2021

  • I am on the latest Poetry version.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option).

Issue

Even though pip allows/standardizes non-lowercase "extras", Poetry does not. It's especially confusing because it silently ignores any "extras" that don't match. I assume this isn't an issue for a most people, because most places use short, lowercase extras; however, Kedro is an example that advocates for mixed-case extras in its docs. Since pip allows it, it would be great if Poetry did, too (our team got burned on it at least twice!).

One way to reproduce this issue (using Conda):

mkdir issue-demo
cd issue-demo/
conda create -n issue-demo python=3.8 -y
conda activate issue-demo
poetry init  # Compatible Python versions:  3.8
poetry add kedro[pandas.CSVDataSet]

Kedro gets installed, but pandas does not. poetry add kedro[pandas.csvdataset] will fix the installation.

The way I figured out what was happening was thanks to a very helpful explanation from @sdispater in #79 (comment). https://pypi.org/pypi/kedro/json indeed yields all-lowercase "extras" in requires_dist.

@deepyaman deepyaman added kind/bug Something isn't working as expected status/triage This issue needs to be triaged labels Jun 1, 2021
@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Jun 11, 2022
Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants