Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to have poetry add git+https://... saves to current directory #2188

Open
ekcolysp opened this issue Mar 16, 2020 · 0 comments
Open
Labels
kind/feature Feature requests/implementations

Comments

@ekcolysp
Copy link

ekcolysp commented Mar 16, 2020

  • [x ] I have searched the issues of this repo and believe that this is not a duplicate.
  • [x ] I have searched the documentation and believe that my question is not covered.

Feature Request

Various projects I am working on requires separation of code into multiple different modules (and hence repositories). I can do this with pip via pip install -e git+https://.../my-module.git and it saves it into src/my-module in editable mode.

https://github.com/boto/boto3/blob/develop/requirements.txt is an example I found that has this pattern, where botocore got imported into boto inside src/.

This is important during development because you can work on both code bases at the same time such as updating the logic in my-module while running integration tests in your main project.

This pattern is commonly used in PHP's composer with the --preferred-source flag (which is equivalent to editable mode). The package will be checked out as a git repo inside the vendor directory where you can make any necessary modifications etc independently of the main project.

I've been looking through the code and I can't seem to find a way to do this with poetry 1.0.5. Currently it does a git checkout into the venv's src/my-module as a headless commit. Alternatively, you can add with a path, but that requires 2 packages sitting side by side, which is not always the case for various development setup.

I was hoping #755 would solve this issue, but it addresses a different problem altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

No branches or pull requests

1 participant