Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry develop doesn't install dependencies defined by path as editable #207

Closed
cauebs opened this issue Jun 12, 2018 · 5 comments
Closed

Comments

@cauebs
Copy link
Contributor

cauebs commented Jun 12, 2018

Steps to reproduce:

~ $ git clone https://github.com/sdispater/poetry
~ $ git clone https://github.com/sdispater/cleo
~ $ cd poetry
# edit ~/poetry/pyproject.toml to change cleo's line to
# cleo = { path = "/home/<user>/test/cleo" }
~/poetry $ poetry develop
...
~/poetry $ source .venv/bin/activate.fish
(.venv) ~/poetry $ python -q
>>> import cleo
>>> cleo.__file__
'/home/<user>/test/poetry/.venv/lib/python3.6/site-packages/cleo/__init__.py'

What is expected: cleo is installed as editable and cleo.__file__ is /home/<user>/cleo/cleo/__init__.py

Using poetry install --develop=cleo instead of poetry develop works as expected.

@cauebs
Copy link
Contributor Author

cauebs commented Jun 12, 2018

Ok, I'm looking into develop and it seems it just calls install with no parameters.
https://github.com/sdispater/poetry/blob/master/poetry/console/commands/develop.py#L41

Additionally, it installs the current project in the venv with -e and --no-deps.

So, I must ask, is this actually the intended behaviour and I was wrong in expecting something different?
If that's not the case, how should dependencies specified by a path be handled?

@jacebrowning
Copy link
Contributor

develop has been deprecated, but this still appears to be an issue with install

And $ poetry install --develop=<dependency_name> is still a valid workaround.

@sdispater
Copy link
Member

@jacebrowning From release 0.12.0 and onward all path dependencies should be installed in editable mode by default. Is this not the case?

@jacebrowning
Copy link
Contributor

@sdispater Hmm, I cannot reproduce this. I think I also updated Poetry in the past few days.

This issue can be closed as far as I'm concerned.

Copy link

github-actions bot commented Mar 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants