-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleNotFoundError for keyring.util.escape in Docker image (poetry 1.0.0 and 1.0.0b9) #1719
Comments
Just realized that poetry 1.0.0 released this past hour, will update the issue once testing with the non-prerelease version. |
Updated the issue, confirmed that the bug is present in 1.0.0 and 1.0.0b9 |
Possibly related, may describe proper solutions: It appears as though there is a bug with the system-installed version of |
I've tried upgrading
|
Hello @TheButlah , is this related: #221 ? fin swimmer |
No clue, but note that I'm not using poetry to install a project, but rather just trying to run any poetry command after installing the poetry tool itself. That is, given the dockerfile setup I posted, the second of the two commands triggers the error:
|
@TheButlah the issue that you are hitting here is the same as the root cause of #1427, which is described in #1427 (comment). TLDR version is to add the following to your ENV LANG C.UTF-8 |
After adding
to the top of my dockerfile, I get the same error when not upgrading
But, after adding
TLDR: upgrading |
I believe this indicates that poetry needs to vendor |
@TheButlah sorry, I should have been clearer on my comment. I was talking about the unicode issue only. As for the issue regarding While explicitly locking the minimum version will resolve the problem for this particular distribution but could open up concerns on other platforms. From the package documentation:
The root issue (for the crash at least), however, seems like is a problem in the keyring backends error handling. And since all available (even unused) backends are dynamically loaded, the error is triggered. If the logging was fixed, it would simply log an exception and continue execution.
Personally, I think poetry should not specify the package as a dependency as it does not explicitly use them. |
Ah, ok. I understand and agree on the rationale for not providing the backend as a dependency as it is system dependent and dynamically loaded. What then is the recommended course of action right now? Is this a bug in |
@TheButlah I have submitted a PR for fixing the logging issue in keyring (jaraco/keyring#417). Good questions regarding the next steps. I'd be inclined to say that this is a troubleshooting entry for poetry project if anything. Hopefully, the distro bug will be resolved with an update and a new container image will be published with that for downstream consumption. |
@abn To clarify, the PR you submitted was for the Unicode error or the ModuleNotFound error? |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
-vvv
option).nvidia/cuda:10.2-cudnn7-devel-ubuntu18.04
Issue
Attempted an install of poetry in my docker file. The install succeeds, but running any poetry commands gives a strange error. I've shown the docker build (trimmed down) along with the error below.
Docker Build output (Trimmed down for brevity):
The text was updated successfully, but these errors were encountered: