From 6e7f17cc81cfd0ffcb90c3fff08f31fb2f3f2e56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Randy=20D=C3=B6ring?= <30527984+radoering@users.noreply.github.com> Date: Sun, 19 Feb 2023 06:32:02 +0100 Subject: [PATCH] performance: cache parsed markers --- src/poetry/core/version/markers.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/poetry/core/version/markers.py b/src/poetry/core/version/markers.py index 7c12a34db..9d36a9703 100644 --- a/src/poetry/core/version/markers.py +++ b/src/poetry/core/version/markers.py @@ -1,8 +1,11 @@ from __future__ import annotations +import functools import itertools import re +from abc import ABC +from abc import abstractmethod from typing import TYPE_CHECKING from typing import Any from typing import Callable @@ -53,10 +56,12 @@ class UndefinedEnvironmentName(ValueError): _parser = Parser(GRAMMAR_PEP_508_MARKERS, "lalr") -class BaseMarker: +class BaseMarker(ABC): + @abstractmethod def intersect(self, other: BaseMarker) -> BaseMarker: raise NotImplementedError() + @abstractmethod def union(self, other: BaseMarker) -> BaseMarker: raise NotImplementedError() @@ -66,24 +71,37 @@ def is_any(self) -> bool: def is_empty(self) -> bool: return False + @abstractmethod def validate(self, environment: dict[str, Any] | None) -> bool: raise NotImplementedError() + @abstractmethod def without_extras(self) -> BaseMarker: raise NotImplementedError() + @abstractmethod def exclude(self, marker_name: str) -> BaseMarker: raise NotImplementedError() + @abstractmethod def only(self, *marker_names: str) -> BaseMarker: raise NotImplementedError() + @abstractmethod def invert(self) -> BaseMarker: raise NotImplementedError() def __repr__(self) -> str: return f"<{self.__class__.__name__} {str(self)}>" + @abstractmethod + def __hash__(self) -> int: + raise NotImplementedError() + + @abstractmethod + def __eq__(self, other: object) -> bool: + raise NotImplementedError() + class AnyMarker(BaseMarker): def intersect(self, other: BaseMarker) -> BaseMarker: @@ -725,6 +743,7 @@ def is_empty(self) -> bool: return all(m.is_empty() for m in self._markers) +@functools.lru_cache(maxsize=None) def parse_marker(marker: str) -> BaseMarker: if marker == "": return EmptyMarker()