-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for tag URIs #9
Comments
I think the focus on the tag scheme is a bit odd. Of the over 300 URI schemes registered with IANA, tag is not the third-most important. But it's a great example for a semi-exotic URI/scheme, especially because we have the linked test case (low hanging fruit). |
Those schemes are basically similar in syntax to other ones (well, HTTP), and they're also "old", so it's unlikely an implementation that works for one will fail on another. Tag is both newer and also "different" even from URN because of the commas, so it seemed more likely that some language will not necessarily have good Meanwhile I don't expect any to have issue with any of the above "in reality", but I'm ok with adding tests for any or all if you're interested! |
I think I do think I just looked through the examples and noticed that very common and meaningful elements of many URI schemes (e.g. https) such as |
PR definitely welcome! #8 is essentially the existing issue for
Empty fragments are definitely there, see e.g. absolute-uri-empty-fragment.json -- Non-empty fragments aren't valid in IDs (IIRC in any version but I forget). I think query strings aren't either, but I also forget. If you do check and find them valid, PR certainly welcome there too (or else an issue). |
We have tests for HTTP(s) and URN schemed URIs.
It probably couldn't hurt to have some for the tag scheme.
At least one example is here.
The text was updated successfully, but these errors were encountered: