(Encoded)URL round-tripping of + in query #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before:
>>> URL(scheme='https', host='foo', query={'f+o o': 'b+a r'}).to_text()
'https://foo/?f%2Bo o=b%2Ba r'
After:
>>> URL(scheme='https', host='foo', query={'f+o o': 'b+a r'}).to_text()
'https://foo/?f+o o=b+a r'
If spaces pass unencoded, surely + can.
twm
changed the title
twm
added a commit
to twisted/treq
that referenced
this pull request
Dec 29, 2020
Codecov Report
@@ Coverage Diff @@
## ne-plus-ultra #146 +/- ##
==============================================
Coverage 98.69% 98.69%
==============================================
Files 13 13
Lines 1840 1840
Branches 212 212
==============================================
Hits 1816 1816
Misses 12 12
Partials 12 12
Continue to review full report at Codecov.
|
twm
added a commit
to twisted/treq
that referenced
this pull request
Dec 29, 2020
glyph
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates the failure afflicting twisted/treq#304