Bug in settings.py: AttributeError: 'module' object has no attribute ENABLE_PUSH

[iteras]

h2 updated from h2.settings.ENABLE_PUSH to h2.settings.SettingCodes.ENABLE_PUSH.

Please replace /hyper/http20/connection.py:411 with:
{h2.settings.SettingCodes.ENABLE_PUSH: int(self._enable_push)}

[alexwlchan]

You'll get this error if you install https://github.com/Lukasa/hyper with h2 3.0.0 or higher.

But the setup.py for Lukasa/hyper specifically pins to the 2.x series of h2, precisely to avoid this issue:

https://github.com/Lukasa/hyper/blob/development/setup.py#L79-L81

If you run pip install --upgrade h2>=2.4,<3.0,!=2.5.0, you should resolve this issue.

We could do the proposed change, but we’d have to bump the required version of h2 in hyper (as the SettingCodes object was only added in h2 2.6.0) – I’m not sure if the 2.4.x series is still supported.

[Lukasa]

The 2.4 series is not still supported, so that bump sounds reasonable to me.

[aladagemre]

Any updates on this?

[pgjones]

Hi @aladagemre, I think this is better asked on the hyper tracker, however I think you should take a look at httpx as I believe it to be the successor to hyper.

(As I don't think this is a h2 issue, I'll close. Please reopen if you think otherwise).