-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add saml group links #2367
Conversation
Just ping us here if you get stuck with anything @abhiandthetruth. Thanks for working on this! |
@nejch occupied with some other work atm. Will try to complete soon |
be68738
to
87a2105
Compare
Codecov Report
@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 95.96% 95.97%
=======================================
Files 80 80
Lines 5331 5342 +11
=======================================
+ Hits 5116 5127 +11
Misses 215 215
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@nejch can you have a look? |
note to self:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work here @abhiandthetruth! The request body matcher in the unit tests will really help with confidence until we have a functional test setup for this.
I've squashed the commits here as the others weren't strictly for the changelog as a feat
:)
CLOSES #2270