chore: update annotations #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <[email protected]>
|
cc @Tinche |
A few notes: - Use UnionType when cattrs decides to support 3.11 since in 3.11 @Final has a different implementation, which inherently affects UnionType support in _compat.py For cattrs to support it we might need to update typing_extensions version - Making generated function a generic type alias now. This should make it easiert to type hint any future works that involves the given make and gen function. revert: changes from upstream Signed-off-by: Aaron Pham <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 91.02% 96.97% +5.94%
==========================================
Files 16 16
Lines 1382 1387 +5
==========================================
+ Hits 1258 1345 +87
+ Misses 124 42 -82
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks! |
|
This change results in the following mypy error in my dependent project: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bad merge and update annotations from #288
Address comments type syntax to newer syntax.