Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore inherited field when comparing Attributes #684

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

hynek
Copy link
Member

@hynek hynek commented Sep 2, 2020

Although technically, inherited is part of the structure, practically it exposes a very confusing behavior because by subclassing the attribute suddenly doesn't compare equal although it is equal by all logical standards.

fixes #682

@pganssle pganssle self-requested a review September 2, 2020 16:23
Copy link
Member

@pganssle pganssle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of the PR look good to me, but this needs a changelog entry, no?

@hynek hynek force-pushed the inherited-attrs-eq-hash branch from fcd53c6 to f5875ca Compare September 3, 2020 04:59
@hynek hynek merged commit bfd7bb4 into master Sep 3, 2020
@hynek hynek deleted the inherited-attrs-eq-hash branch September 3, 2020 05:17
hynek added a commit that referenced this pull request Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inherited attributes of subclasses no longer compare equal to the equivalent attributes of base class
2 participants