Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Runner work with unhashable points #267

Closed
basnijholt opened this issue Apr 16, 2020 · 1 comment · Fixed by #268
Closed

Make Runner work with unhashable points #267

basnijholt opened this issue Apr 16, 2020 · 1 comment · Fixed by #268
Labels
enhancement Runner

Comments

@basnijholt
Copy link
Member

Currently Runners do not support the points to be unhashable. This leads to #265.

Allowing the Runner to work with any points would simplify the SequenceLearner and means we wouldn't have to convert numpy arrays to tuples in all other learners.
@basnijholt basnijholt mentioned this issue Apr 16, 2020
Closed
6 tasks
@akhmerov
Copy link
Contributor

means we wouldn't have to convert numpy arrays to tuples in all other learners.

Not necessarily—the other learners might still rely on dictionaries for the internal data structure.

Still the runner doesn't really need to store a lot of state, and making its interface more general is an improvement.

@basnijholt basnijholt mentioned this issue Apr 16, 2020
Merged
6 tasks
@basnijholt basnijholt mentioned this issue May 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Runner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make the Runner work with unhashable points python-adaptive/adaptive
2 participants
@akhmerov @basnijholt