Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate yield_fixtures #3704

Closed
nicoddemus opened this issue Jul 22, 2018 · 2 comments
Closed

Deprecate yield_fixtures #3704

nicoddemus opened this issue Jul 22, 2018 · 2 comments
Labels
type: deprecation feature that will be removed in the future type: feature-branch new feature or API change, should be merged into features branch

Comments

@nicoddemus
Copy link
Member

nicoddemus commented Jul 22, 2018 •
edited by asottile
Loading

I just realized that we never actually deprecated yield_fixtures, only in docs. I think we should start warning with RemovedInPytest4Warnings so eventually we can turn them into errors in pytest 4.0.
@nicoddemus nicoddemus added type: feature-branch new feature or API change, should be merged into features branch type: deprecation feature that will be removed in the future labels Jul 22, 2018
@pytestbot
Copy link
Contributor

GitMate.io thinks possibly related issues are #3661 (deprecate calling fixtures as functions), #3050 (deprecate pytest.config), #1684 (Deprecate "pytest_funcarg__" prefix for fixtures), #3653 (Avoid deprecated attrs feature convert), and #2803 (Deprecate TerminalReporter._tw).

@nicoddemus
Copy link
Member Author

@RonnyPfannschmidt what do you think?

@nicoddemus nicoddemus mentioned this issue Jul 22, 2018
Merged
This was referenced Jul 26, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: deprecation feature that will be removed in the future type: feature-branch new feature or API change, should be merged into features branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicoddemus @pytestbot