-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📝 Replace GH/PyPI extlinks
w/ sphinx-issues
#12522
Conversation
This is a preparatory patch for integrating the third party `sphinx-issues` extension.
This extension implements more generic roles that can also be used more flexibly. Relying on an external extension allows to stop maintaining an in-repo copy of the commonly used behavior.
Apparently, the extension only supports one of the pre-defined prefixes.
@@ -170,13 +171,8 @@ | |||
linkcheck_workers = 5 | |||
|
|||
|
|||
_repo = "https://github.com/pytest-dev/pytest" | |||
extlinks = { | |||
"bpo": ("https://bugs.python.org/issue%s", "bpo-%s"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since BPO is shut down, we might want to switch it to point to cpython github now (not necessary for this PR though).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair, I wasn't sure. But yeah, could be separate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in #12533.
Backport to 8.2.x: 💚 backport PR created✅ Backport PR branch: Backported as #12525 🤖 @patchback |
📝 Replace GH/PyPI `extlinks` w/ `sphinx-issues` (cherry picked from commit 2371525)
…37152552e1782bcfcae402e1540f12348ef9f0e/pr-12522 [PR #12522/23715255 backport][8.2.x] 📝 Replace GH/PyPI `extlinks` w/ `sphinx-issues`
BPO is in read-only mode and all issues have been migrated to GitHub. This patch replaces the use of that role with `:issue:`, recently integrated via pytest-dev#12522. It also disables the built-in `extlinks` Sphinx extension as it's no longer in use.
BPO is in read-only mode and all issues have been migrated to GitHub. This patch replaces the use of that role with `:issue:`, recently integrated via pytest-dev#12522. It also disables the built-in `extlinks` Sphinx extension, as it's no longer in use.
BPO is in read-only mode and all issues have been migrated to GitHub. This patch replaces the use of that role with `:issue:`, recently integrated via pytest-dev#12522. It also disables the built-in `extlinks` Sphinx extension, as it's no longer in use.
This Sphinx extension implements more generic roles that can also be used
more flexibly. Relying on an external extension allows us to stop
maintaining an in-repo copy of the commonly used behavior.
As a part of the change, the
:pull:
RST role is being replaced with:pr:
.