Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.8 #486

Merged
merged 3 commits into from
Nov 22, 2019
Merged

Add support for Python 3.8 #486

merged 3 commits into from
Nov 22, 2019

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 9, 2019

Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

Also rename appveyor.yml to .appveyor.yml. Let's group it with the other dotfiles for consistency and less clutter.

AppVeyor supports dot-file-style YAML named .appveyor.yml as is.

https://www.appveyor.com/docs/build-configuration/#yaml-file-alternative-naming

@nicoddemus
Copy link
Member

Thanks @hugovk!

@nicoddemus nicoddemus merged commit 66e74c8 into pytest-dev:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants