Serialization/Deserialization was dropping longrepr.sections

[timyhou]

This was introduced in PR 164. I forgot to serialize/deserialize the sections attribute from ExceptionRepr which is on longrepr. This affects users who append or modify longrepr.sections for custom reporting.

Wasn't sure if I should have filed an issue first then a PR. This was a stupid oversight on my part. Sorry for the bug.

Here's a quick checklist that should be present in PRs:

• Make sure to include reasonable tests for your change if necessary

• Add a news file into the changelog folder, following these guidelines:

  • Name it $issue_id.$type for example 588.bug

  • If you don't have an issue_id change it to the PR id after creating it

  • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

  • Make sure to use full sentences with correct case and punctuation, for example:

    Fix issue with non-ascii contents in doctest text files.
    

[RonnyPfannschmidt]

just include the pr id in the news fragment

[RonnyPfannschmidt]

change looks good, please add to the news fragment

@nicoddemus as there was no release i wonder if we should skip the news fragment and/or update the existing one

[nicoddemus]

@RonnyPfannschmidt actually I did the 1.18.0 release. 😉

[RonnyPfannschmidt]

oh, i missed, well then please add a news fragment then we will merge and do a patch release ^^

[timyhou]

Added a changelog.

Unrelated - is there a way to skip the checks if the commit change is something trivial like a changelog?

[nicoddemus]

Unrelated - is there a way to skip the checks if the commit change is something trivial like a changelog?

Not AFAIK.

Thanks for adding the changelog!