Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove images2gif and vendor module #164

Open
aerispaha opened this issue Dec 21, 2022 · 0 comments
Open

remove images2gif and vendor module #164

aerispaha opened this issue Dec 21, 2022 · 0 comments
Milestone

Comments

@aerispaha
Copy link
Member

I think there is no reason to house this logic in swmmio. This was used in the past to generate animated data visualizations - cool stuff, but I don't think it makes sense to have a duplicate of the logic that exists in the github.com/isaacgerg/images2gif repository.

Instead, think we could show an example of how to leverage that code in an extended environment (with images2gif installed), rather than having it baked into the swmmio source code.

@bemcdonnell bemcdonnell added this to the v1.0 milestone Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants