Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use custom import hooks to not risk to break python2 #22

Closed
asmodehn opened this issue Jul 17, 2017 · 3 comments
Closed

Do not use custom import hooks to not risk to break python2 #22

asmodehn opened this issue Jul 17, 2017 · 3 comments

Comments

@asmodehn
Copy link
Member

This is suitable before we make a ros package out of this...
@asmodehn
Copy link
Member Author

rosimport is actually only used in tests. moving tests outside of the package seems to be an acceptable solution...
We can assume that someone wanting to test the package will retrieve the source, and there is little point in embedding tests inside the package.

@asmodehn asmodehn mentioned this issue Jul 18, 2017
Closed
@asmodehn
Copy link
Member Author

This has been done in #14, but more testing is needed...

@asmodehn
Copy link
Member Author

Closing since the PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asmodehn